8000 :lock: :robot: CI Update lock files for array-api CI build(s) :lock: :robot: by scikit-learn-bot · Pull Request #29576 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

🔒 🤖 CI Update lock files for array-api CI build(s) 🔒 🤖 #29576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

scikit-learn-bot
Copy link
Contributor

Update lock files.

Note

If the CI tasks fail, create a new branch based on this PR and add the required fixes to that branch.

Copy link
github-actions bot commented Jul 29, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 2454db9. Link to the linter CI: here

@ogrisel ogrisel added CUDA CI and removed CUDA CI labels Jul 29, 2024
@github-actions github-actions bot removed the CUDA CI label Jul 29, 2024
@ogrisel
Copy link
Member
ogrisel commented Jul 29, 2024

@lesteve @betatim I had to manually relabel this PR as the original label set by the @github-actions bot did not trigger the CUDA GPU CI workflow on the original 8f91a46 commit for some reason.

After pushing an empty commit, syncing with main (probably not necessary) and then removing and readding the label I see that the worflow was successfully triggered:

https://github.com/scikit-learn/scikit-learn/actions/runs/10141110347/job/28037662041?pr=29576

Any idea why the first label by @github-actions was not enough?

@lesteve
Copy link
Member
lesteve commented Jul 29, 2024

@lesteve @betatim I had to manually relabel this PR as the original label set by the @github-actions bot did not trigger the CUDA GPU CI workflow on the original 8f91a46 commit for some reason.

Yep I have seen the same as well last week, no idea why, I remove and added the CUDA CI label manually which worked #29537 (comment) ...

@ogrisel ogrisel enabled auto-merge (squash) July 29, 2024 09:18
@ogrisel ogrisel merged commit baebca1 into scikit-learn:main Jul 29, 2024
34 checks passed
@betatim
Copy link
Member
betatim commented Jul 29, 2024

Good question. Removing and adding the label is what will trigger the workflow. It is configured to react to the "label" event, so new commits don't help.

I have no good idea right away why it didn't get triggered. I tried to find a log of all the events related to the repository and/or a way each time a workflow is triggered and evaluates the if conditions in it. But couldnt' find it. Two things I think could be related: use of force push and that the workflow that adds the label is somehow not privileged enough/it is a workflow triggering a workflow (though I thought that was supported for a certain number of levels)? At least those seem like the two things that are different compared to the cases where it worked

MarcBresson pushed a commit to MarcBresson/scikit-learn that referenced this pull request Sep 2, 2024
…29576)

Co-authored-by: Lock file bot <noreply@github.com>
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
@lesteve
Copy link
Member
lesteve commented Sep 4, 2024

Bumped into this today, maybe the fact that adding the label "CUDA CI" does not trigger the CUDA CI run is because of triggering a workflow from a workflow limitations, see doc. Apparently you need a PAT rather than the default GITHUB_TOKEN when you are in this case. The last example in the doc is very similar to our use case I think:

Conversely, the following workflow uses GITHUB_TOKEN to add a label to an issue. It will not trigger any workflows that run when a label is added.

I don't remember if we have a PAT for some of the CI that we could try to see whether that fixes the issue ...

@lesteve
Copy link
Member
lesteve commented Sep 4, 2024

I created #29781 to track this, because it took me a while to find the relevant PRs where we discussed this 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0