DOC fix dropdown anchor and collapse-all button in sphinx-design==0.6.0
#29493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinjalali
approved these changes
Jul 16, 2024
thomasjpfan
approved these changes
Jul 20, 2024
There was a problem hiding this comment.
@Charlie-XIAO How did you catch this issue?
In any case, LGTM.
|
Found that dropdowns look weird on dev -> looked at lock files and found sphinx-design was updated -> checked its source code and found it completely changed the implementation |
MarcBresson
pushed a commit
to MarcBresson/scikit-learn
that referenced
this pull request
Sep 2, 2024
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Sep 9, 2024
glemaitre
pushed a commit
that referenced
this pull request
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the latest
sphinx-design==0.6.0, our tweaks on the dropdowns are broken since they refactored the structure. Check for instance this page:This PR makes corresponding updates to retain a similar UI/UX as before. See this corresponding artifact page.