8000 DOC Add lock-file trick to help debug CI issues by lesteve · Pull Request #29435 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

DOC Add lock-file trick to help debug CI issues #29435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 9, 2024

Conversation

lesteve
Copy link
Member
@lesteve lesteve commented Jul 8, 2024

Following discussion about this at the biweekly meeting, this adds a "Debugging CI issues" to the Developers tips with "Using a lock-file to get an environment close to the CI" as its first entry.

@lesteve lesteve removed the API label Jul 8, 2024
@lesteve lesteve changed the title DOC Add lock-file trick to debug CI issues DOC Add lock-file trick to help debug CI issues Jul 8, 2024
Copy link
github-actions bot commented Jul 8, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: f7b7c11. Link to the linter CI: here

Copy link
Member
@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

/cc @ArturoAmorQ

Copy link
Member
@ArturoAmorQ ArturoAmorQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @lesteve, this is a a really useful contribution. Just a couple of comments but otherwise LGTM :)

lesteve and others added 2 commits July 9, 2024 11:09
Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
@lesteve
Copy link
Member Author
lesteve commented Jul 9, 2024

All right, thanks for the review, let's merge my own PR with 2 approvals. This can always be improved later if the need arises.

@lesteve lesteve merged commit df25e37 into scikit-learn:main Jul 9, 2024
30 checks passed
@lesteve lesteve deleted the add-lock-file-trick branch July 9, 2024 13:13
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Sep 9, 2024
Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
glemaitre pushed a commit that referenced this pull request Sep 11, 2024
Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0