ENH Add array_api compatibility to dcg_score
#29339
Open
+141
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmarManzoor
reviewed
Jul 24, 2024
| discount_cumsum = np.cumsum(discount) | ||
| cumulative_gains = [ | ||
| _tie_averaged_dcg(y_t, y_s, discount_cumsum) | ||
| for y_t, y_s in zip(y_true, y_score) |
There was a problem hiding this comment.
Won't something like this work generically?
Suggested change
| for y_t, y_s in zip(y_true, y_score) | |
| for y_t, y_s in xp.stack((y_true, y_score), axis=1) |
There was a problem hiding this comment.
this seems to make array_api_strict complain if y_true and y_score don't have the same type (like in this test case): TypeError: array_api_strict.int64 and array_api_strict.float64 cannot be type promoted together
(array_api_strict complained a lot while working on this 😅)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #26024
What does this implement/fix? Explain your changes.
It makes the
dcg_scoreimplementation compatible and tested with the Array API.Any other comments?
TODOs
zipdoesn't seem to work witharray_api_strictneed to investigate (or find an alternative)_cumulative_sumtoutils(and change name to_cumulative_sum1dbecause does always_ravel)float.64withmpsVery happy to hear your feedback on how to improve this. (Mostly regarding the issue with Array API strict) I'm also a bit unsure if we have to split always numpy vs array-api in this case
cc @ogrisel @OmarManzoor