FEA SLEP006: Metadata routing for validation_curve
#29329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam2392
reviewed
Jun 21, 2024
Comment on lines
2347
to
2352
| Parameters directly passed to the `fit` method of the estimator. | ||
|
|
||
| - If `enable_metadata_routing=True`: | ||
| Parameters safely routed to the `fit` method of the estimator. | ||
| See :ref:`Metadata Routing User Guide <metadata_routing>` for more | ||
| details. |
There was a problem hiding this comment.
Same comment here. Since it's passed to more than the estimator fit. There's the scorer and CV
There was a problem hiding this comment.
Thank you @adam2392, that comment also made it more clear for myself.
Co-authored-by: Adam Li <adam2392@gmail.com>
StefanieSenger
commented
Jun 23, 2024
There was a problem hiding this comment.
I've submitted your suggestions, @adam2392, thanks for your review.
Comment on lines
2347
to
2352
| Parameters directly passed to the `fit` method of the estimator. | ||
|
|
||
| - If `enable_metadata_routing=True`: | ||
| Parameters safely routed to the `fit` method of the estimator. | ||
| See :ref:`Metadata Routing User Guide <metadata_routing>` for more | ||
| details. |
There was a problem hiding this comment.
Thank you @adam2392, that comment also made it more clear for myself.
adrinjalali
reviewed
Jul 5, 2024
@adrinjalali |
adrinjalali
approved these changes
Jul 5, 2024
28 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
towards #22893
What does this implement/fix? Explain your changes.
Adds metadata routing to
validation_curveand the corresponding tests.This PR is almost identical to #28975