8000 FEA Add metadata routing for RFE and RFECV by OmarManzoor · Pull Request #29312 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content
8000

FEA Add metadata routing for RFE and RFECV #29312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Aug 13, 2024
Merged

FEA Add metadata routing for RFE and RFECV #29312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
7843fbe
FEA Add metadata routing for RFE and RFECV
OmarManzoor Jun 20, 2024
eb89981
Add changelog entry
OmarManzoor Jun 20, 2024
faa80ed
Remove uncessary change
OmarManzoor Jun 20, 2024
b4c6a46
Fix versionadded
OmarManzoor Jun 20, 2024
35f22b3
Add a test to verify that rfe works correctly with sample weights
OmarManzoor Jun 21, 2024
b6a41b3
Merge branch 'main' into rfe_routing
OmarManzoor Jun 21, 2024
75e02b9
Add missing _raise_for_params in newly added params
OmarManzoor Jun 21, 2024
73bddcc
Keep groups as an argument
OmarManzoor Jun 21, 2024
6156b8e
Update: pr suggestions
OmarManzoor Jul 5, 2024
9d42300
Merge branch 'main' into rfe_routing
OmarManzoor Jul 8, 2024
52e14bb
Merge branch 'main' into rfe_routing
OmarManzoor Jul 12, 2024
78cc39f
Add _deprecate_positional_args for groups
OmarManzoor Jul 12, 2024
010ffb0
Merge branch 'main' into rfe_routing
OmarManzoor Jul 25, 2024
87775b2
Updates PR suggestions
OmarManzoor Jul 25, 2024
c5a31cf
Merge branch 'main' into rfe_routing
OmarManzoor Aug 1, 2024
5e9dc93
Updates: according to PR suggestion
OmarManzoor Aug 7, 2024
fc36994
Merge branch 'main' into rfe_routing
OmarManzoor Aug 8, 2024
21f19c0
Further updates
OmarManzoor Aug 8, 2024
c3617b7
Add score in scorer_routing_methods for testing RFECV
OmarManzoor Aug 8, 2024
2b860e2
Add a comment explaining the DELEGATING_METAESTIMATORS
OmarManzoor Aug 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions doc/metadata_routing.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,8 @@ Meta-estimators and functions supporting metadata routing:
- :class:`sklearn.ensemble.VotingRegressor`
- :class:`sklearn.ensemble.BaggingClassifier`
- :class:`sklearn.ensemble.BaggingRegressor`
- :class:`sklearn.feature_selection.RFE`
- :class:`sklearn.feature_selection.RFECV`
- :class:`sklearn.feature_selection.SelectFromModel`
- :class:`sklearn.feature_selection.SequentialFeatureSelector`
- :class:`sklearn.impute.IterativeImputer`
Expand Down Expand Up @@ -323,5 +325,3 @@ Meta-estimators and tools not supporting metadata routing yet:

- :class:`sklearn.ensemble.AdaBoostClassifier`
- :class:`sklearn.ensemble.AdaBoostRegressor`
- :class:`sklearn.feature_selection.RFE`
- :class:`sklearn.feature_selection.RFECV`
4 changes: 4 additions & 0 deletions doc/whats_new/v1.6.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,10 @@ more details.
for the `fit` method of its estimator and for its underlying CV splitter and scorer.
:pr:`29266` by :user:`Adam Li <adam2392>`.

- |Feature| :class:`feature_selection.RFE` and :class:`feature_selection.RFECV`
now support metadata routing.
:pr:`29312` by :user:`Omar Salman <OmarManzoor>`.

Dropping support for building with setuptools
---------------------------------------------

Expand Down
Loading
Loading
0