8000 DOC add persistence methods table by adrinjalali · Pull Request #29215 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

DOC add persistence methods table #29215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 25, 2024
Merged

DOC add persistence methods table #29215

merged 9 commits into from
Jul 25, 2024

Conversation

adrinjalali
Copy link
Member

This adds a table to summarize persistence methods as suggested by @ogrisel (ref: #29011 (comment))

@github-actions GitHub Actions
Copy link
github-actions bot commented Jun 8, 2024 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 6d823ae. Link to the linter CI: here

ogrisel
ogrisel reviewed Jun 10, 2024
View reviewed changes
Copy link
Member
@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for the follow-up Adrin. Here is some feedback.

adrinjalali and others added 6 commits June 10, 2024 11:57
@adrinjalali @ogrisel
Update doc/model_persistence.rst
772994c 
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
@adrinjalali @ogrisel
Update doc/model_persistence.rst
1562a4d 
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
@adrinjalali @ogrisel
Update doc/model_persistence.rst
6bf9771 
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
@adrinjalali @ogrisel
Update doc/model_persistence.rst
a9cb668 
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
@adrinjalali @ogrisel
Update doc/model_persistence.rst
a8eb8fc 
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
@adrinjalali
remove no memory mapping
9e3040d
ogrisel
ogrisel approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member
@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the table rendering is fixed, +1 for merge.

@adrinjalali @ogrisel
Update doc/model_persistence.rst
6d823ae 
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
@adrinjalali
Copy link
Member Author

cc @ArturoAmorQ

@glemaitre glemaitre merged commit 2ffe206 into scikit-learn:main Jul 25, 2024
30 checks passed
@glemaitre
Copy link
Member

LGTM. Thanks @adrinjalali

@adrinjalali adrinjalali deleted the persist/doc branch July 25, 2024 08:44
MarcBresson pushed a commit to MarcBresson/scikit-learn that referenced this pull request Sep 2, 2024
@adrinjalali @ogrisel @MarcBresson
DOC add persistence methods table (scikit-learn#29215)
d81a882 
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Sep 9, 2024
@adrinjalali @ogrisel @glemaitre
DOC add persistence methods table (scikit-learn#29215)
4ba9a08 
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
glemaitre pushed a commit that referenced this pull request Sep 11, 2024
@adrinjalali @ogrisel @glemaitre
DOC add persistence methods table (#29215)
494d1c0 
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adrinjalali @glemaitre @ogrisel
0