MAINT cleanup utils.__init__: deprecate tosequence #28763
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #26686 to ease the reviews. The end goal is to clean the
utils.__init__
module as explained in the linked PR.The only current usage of
tosequence
is in a single test, to turn amap
into alist
. I don't think we really need to keep it in the codebase. It's not a public function but since it's available fromsklearn.utils
and doesn't have a leading underscore, let's be extra safe and follow the deprecation cycle, unless you think otherwise and I'll be happy to just remove it right away :)