8000 DOC: Add dropdowns to Module 1.14 Semi Supervised by jmarintur · Pull Request #28615 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

DOC: Add dropdowns to Module 1.14 Semi Supervised #28615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

jmarintur
Copy link
Contributor

This PR addd dropdowns to submodule 1.14 semi supervised.
Issue: #26617

Folded:

  • 1.14.1
    Reference
  • 1.14.2
    References

Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 77f9b3e. Link to the linter CI: here

Copy link
Member
@ArturoAmorQ ArturoAmorQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jmarintur thanks for your time and interest in contributing :)

Unfortunately, the current implementation of the dropdowns breaks the cross-referencing systems whenever a reference points inside a dropdown (it's a mozilla bug), in such cases we rather don't use them.

In any case this section of the user guide is short enough not to need the implementation of dropdowns.

@jmarintur
Copy link
Contributor Author

Hi @ArturoAmorQ, thank you for your message. I wanted to go through the whole "good first issue" process, and I grabbed the first one that was not implemented. May I go for another one with more content or simply jump into another issue? Happy to contribute :D

@ArturoAmorQ
Copy link
Member

You can still add dropdowns to the Contributing Guide.

There I would use them to hide by default the following:

Please let me know if you need help in doing so :)

@ArturoAmorQ
Copy link
Member

Provided that #28624 is already a nice follow-up, maybe we can close this PR if you don't mind.

Sign up for free to join this conversation on GitHub. Already have an 6247 account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0