8000 DOC: Adding dropdowns to contributing guide by jmarintur · Pull Request #28624 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

DOC: Adding dropdowns to contributing guide #28624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

jmarintur
Copy link
Contributor
@jmarintur jmarintur commented Mar 13, 2024

Related to #26617.

Following the suggestion of adding dropdowns in the Contributing Guide made by @ArturoAmorQ in #28615 (comment). These are the subsections/parts this PR modifies:

Copy link
github-actions bot commented Mar 13, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: ccdf508. Link to the linter CI: here

Copy link
Member
@ArturoAmorQ ArturoAmorQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for being so quick to address my comment :)
Just a nit but otherwise LGTM!

Improving text

Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
@ArturoAmorQ
Copy link
Member

Thanks again, merging 🚀

@ArturoAmorQ ArturoAmorQ merged commit e5ce4bc into scikit-learn:main Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0