8000 DOC Add a docstring example for sklearn.datasets.make_checkerboard by lamdang2k · Pull Request #28427 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

DOC Add a docstring example for sklearn.datasets.make_checkerboard #28427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 26, 2024
Merged

DOC Add a docstring example for sklearn.datasets.make_checkerboard #28427

merged 10 commits into from
Feb 26, 2024

Conversation

lamdang2k
Copy link
Contributor
@lamdang2k lamdang2k commented Feb 15, 2024 •
edited by Charlie-XIAO
Loading

Reference Issues/PRs

#27982

What does this implement/fix? Explain your changes.

Write an example for make_checkerboard function

Any other comments?

@github-actions GitHub Actions
Copy link
github-actions bot commented Feb 15, 2024 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 0c24430. Link to the linter CI: here

@lamdang2k lamdang2k marked this pull request as draft February 15, 2024 09:52
@lamdang2k lamdang2k marked this pull request as ready for review February 19, 2024 13:38
@Charlie-XIAO
Copy link
Contributor

We might need to close this in favor of the earlier PR #28342, sorry about that @lamdang2k. You may take over if that one is confirmed to be stalled.

@lamdang2k lamdang2k changed the title DOC Add a docstring example for sklearn.datasets.make_biclusters DOC Add a docstring example for sklearn.datasets.make_checkerboard Feb 21, 2024
@lamdang2k
Copy link
Contributor Author

We might need to close this in favor of the earlier PR #28342, sorry about that @lamdang2k. You may take over if that one is confirmed to be stalled.

@Charlie-XIAO I just realize that there is a mistake in the PR name, in fact I added an example of make_checkerboard, not make_bicluster. Could you check if there is anyone working on this function? Sorry for any confusion this may have caused.

@Charlie-XIAO
Copy link
Contributor

Ah sorry I didn't look into the actual changes. Will reopen: sorry for the mistake.

@Charlie-XIAO Charlie-XIAO reopened this Feb 21, 2024
Charlie-XIAO
Charlie-XIAO reviewed Feb 21, 2024
View reviewed changes
Copy link
Contributor
@Charlie-XIAO Charlie-XIAO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the comments are resolved. Thanks @lamdang2k!

@Charlie-XIAO
Copy link
Contributor

CI is failing. The reason is that the section should be named "Examples" instead of "Example". See numpydoc standard if you are interested.

Charlie-XIAO
Charlie-XIAO approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor
@Charlie-XIAO Charlie-XIAO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @lamdang2k!

@Charlie-XIAO Charlie-XIAO added Quick Review For PRs that are quick to review Waiting for Second Reviewer First reviewer is done, need a second one! and removed module:decomposition labels Feb 22, 2024
thomasjpfan
thomasjpfan reviewed Feb 23, 2024
View reviewed changes
Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @lamdang2k !

ArturoAmorQ
ArturoAmorQ approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member
@ArturoAmorQ ArturoAmorQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @lamdang2k, merging :)

@ArturoAmorQ ArturoAmorQ merged commit d74a5a5 into scikit-learn:main Feb 26, 2024
@lamdang2k lamdang2k deleted the make_checkerboard branch March 1, 2024 09:55
@reshamas reshamas removed the Waiting for Second Reviewer First reviewer is done, need a second one! label Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan left review comments

@ArturoAmorQ ArturoAmorQ ArturoAmorQ approved these changes

@Charlie-XIAO Charlie-XIAO Charlie-XIAO approved th 596F ese changes

Assignees
No one assigned
Labels
Documentation module:datasets Quick Review For PRs that are quick to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lamdang2k @Charlie-XIAO @thomasjpfan @ArturoAmorQ @reshamas
0