8000 CLN Support _MultimetricScorer directly for internal methods by thomasjpfan · Pull Request #28359 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

CLN Support _MultimetricScorer directly for internal methods #28359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 6, 2024
Merged

CLN Support _MultimetricScorer directly for internal methods #28359

merged 2 commits into from
Feb 6, 2024

Conversation

thomasjpfan
Copy link
Member

Reference Issues/PRs

Closes #27001

What does this implement/fix? Explain your changes.

This PR simplifies the handling of multi-metric scoring, by always converting scoring dicts to a _MultimetricScorer at the start of a public function call.

@thomasjpfan thomasjpfan changed the title CI Fix assign/unassign CI CLN Support _MultimetricScorer directly for internal methods Feb 4, 2024
@github-actions GitHub Actions
Copy link
github-actions bot commented Feb 4, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 0276c92. Link to the linter CI: here

@thomasjpfan thomasjpfan mentioned this pull request Feb 4, 2024
Merged
adrinjalali
adrinjalali approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member
@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works. I wanted to do a similar thing while working on slep6, but it seemed dirty. I like this reverse if on _MultimetricScorer now.

Sorry, something went wrong.

@adrinjalali adrinjalali added the Quick Review For PRs that are quick to review label Feb 6, 2024
@adrinjalali
Copy link
Member

@OmarManzoor maybe you could have a look? Should be a quick review.

OmarManzoor
OmarManzoor approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor
@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @thomasjpfan

@OmarManzoor OmarManzoor merged commit cf1fb22 into scikit-learn:main Feb 6, 2024
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Feb 10, 2024
@thomasjpfan @glemaitre
CLN Support _MultimetricScorer directly for internal methods (scikit-…
7bdc959 
…learn#28359)
@StefanieSenger StefanieSenger mentioned this pull request May 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrinjalali adrinjalali adrinjalali approved these changes

@OmarManzoor OmarManzoor OmarManzoor approved these changes

Assignees
No one assigned
Labels
module:model_selection No Changelog Needed Quick Review For PRs that are quick to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor cross_validate to pass around _MultimetricScorer
3 participants
@thomasjpfan @adrinjalali @OmarManzoor
0