CI Unpin pytest and regenerate lock-files #28318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So the CI is green but codecov fails to upload see build log. One example where having disallowed "Bypass required checks" is a minor downside. I have retriggered the failing build and it passes. |
adrinjalali
approved these changes
Jan 31, 2024
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Feb 10, 2024
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Feb 13, 2024
glemaitre
pushed a commit
that referenced
this pull request
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly a behaviour changes from https://docs.pytest.org/en/stable/changelog.html#other-breaking-changes
I think this behaviour change makes sense and adapting our tests is easy and not controversial.
and a work-around for a pytest bug: pytest-dev/pytest#11872
It seems like
pytest --pyargs sklearnin pytest 8 does not discover tests with Meson editable install for some weird reason, it could be because of collection changes in Pytest 8 maybe https://docs.pytest.org/en/stable/changelog.html#collection-changes? It seems like a meson-python issue actually, I have opened mesonbuild/meson-python#568. I thinkpytest --pyargsis actually broken in editable installs and is somehow working by chance withpytest<8