8000 DOC add docstring for inplace_csr_row_normalize_l1 and inplace_csr_row_normalize_l2 by Higgs32584 · Pull Request #28286 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

DOC add docstring for inplace_csr_row_normalize_l1 and inplace_csr_row_normalize_l2 #28286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 2, 2024
Merged

DOC add docstring for inplace_csr_row_normalize_l1 and inplace_csr_row_normalize_l2 #28286

merged 8 commits into from
Mar 2, 2024

Conversation

Higgs32584
Copy link
Contributor

@github-actions GitHub Actions
Copy link
github-actions bot commented Jan 26, 2024 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: a953e3b. Link to the linter CI: here

@Higgs32584
Copy link
Contributor Author

@glemaitre

@Higgs32584
Copy link
Contributor Author

@glemaitre Could you review this? That would be greatly appreciated. Thank you for your time.

@glemaitre
Copy link
Member
glemaitre commented Feb 1, 2024 via email

@Higgs32584
Copy link
Contributor Author
8000

@glemaitre of course I understand. Is there something else I can work on that would help you guys out? Thank you again

@Higgs32584
Copy link
Contributor Author

@glemaitre I haven't gotten a non documentation commit yet and i want to help out

@glemaitre glemaitre self-requested a review March 2, 2024 10:39
@glemaitre glemaitre changed the title #27982 added examples for sklearn.utils.sparsefuncs_fast.inplace_csr_row_normalize_l1 and sklearn.utils.sparsefuncs_fast.inplace_csr_row_normalize_l2 DOC add docstring for inplace_csr_row_normalize_l1 and inplace_csr_row_normalize_l2 Mar 2, 2024
glemaitre
glemaitre approved these changes Mar 2, 2024
View reviewed changes
Copy link
Member
@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I slightly modified the docstring such that we also document the input parameters.

@glemaitre glemaitre enabled auto-merge (squash) March 2, 2024 11:00
@glemaitre
Copy link
Member

Enabling auto-merge. Thanks @Higgs32584

@glemaitre glemaitre merged commit 1c93eb3 into scikit-learn:main Mar 2, 2024
@Higgs32584 Higgs32584 deleted the sparsefuncs branch March 2, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre 56AF glemaitre approved these changes

Assignees
No one assigned
Labels
cython Documentation module:utils
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Higgs32584 @glemaitre
0