FEA Support missing-values in ExtraTrees*
#28268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
… into extratreenan
Signed-off-by: Adam Li <adam2392@gmail.com>
… into extratreenan
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
… into extratreenan
… into extratreenan
Signed-off-by: Adam Li <adam2392@gmail.com>
…into extraforest
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
OmarManzoor
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
LGTM. Thanks @adam2392. Would it be suitable for ExtraTreesRegressor to be added to test_non_supported_criterion_raises_error_with_missing_values?
Co-authored-by: Omar Salman <omar.salman2007@gmail.com>
Co-authored-by: Omar Salman <omar.salman2007@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
…into extraforest
|
Good point @OmarManzoor! Added in 1441925 |
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Follow-up to: #27966
Closes: #27931
What does this implement/fix? Explain your changes.
ExtraTrees*Any other comments?
This should be a very easy review as this just activates the usage of missing value support and adds unit-test parameterizations for the ExtraTree Forest. Just requesting reviews from @thomasjpfan, @glemaitre and @OmarManzoor since you all were able to review the code in #27966. Hope this is easy :)
Waiting for #27966 to be merged first.This just shows the relevant code changes that introduces the missing-value support overall forExtraTrees. Note the bulk of the work for going from tree->forest missing-value support was added in #26391. The main change here is to introduce certain unit tests.ExtraTrees*perform much better on data with missing values compared to naive imputation onmainExtraTree*compared to naive imputation onmainBenchmarks on ExtraTrees demonstrating there is no runtime regression