MAINT fix tests by passing 1d vector to unique #28137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Agreed, for reference the numpy change is likely numpy/numpy#25553 |
lesteve
approved these changes
Jan 17, 2024
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Jan 17, 2024
…n#28137) Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
jeremiedbb
pushed a commit
that referenced
this pull request
Jan 17, 2024
Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Feb 10, 2024
…n#28137) Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #28126
The returned of
np.uniquecontaining the index has now the same shape than the input data (that is consistent). The previous test was expecting that if you pass a column or row matrix, the output will be equivalent to a vector.I think that the change of behaviour of NumPy is legitimate and it only break the code in a test. So we don't have to report any regression here.