8000 ENH TfidfTransformer perserves np.float32 dtype by glemaitre · Pull Request #28136 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

ENH TfidfTransformer perserves np.float32 dtype #28136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jan 18, 2024
Merged

ENH TfidfTransformer perserves np.float32 dtype #28136

merged 12 commits into from
Jan 18, 2024

Conversation

glemaitre
Copy link
Member
@glemaitre glemaitre commented Jan 15, 2024 •
edited
Loading

Towards #11000

Follow-up to #18843

This PR allows the TfidfTransformer to make the computation using np.float32 without additional conversion.

As a free launch, the TfidfVectorizer should make less copy when setting dtype=np.float32.

@github-actions GitHub Actions
Copy link
github-actions bot commented Jan 15, 2024 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 70848bc. Link to the linter CI: here

@glemaitre glemaitre mentioned this pull request Jan 15, 2024
Merged
thomasjpfan
thomasjpfan approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

OmarManzoor
OmarManzoor reviewed Jan 18, 2024
View reviewed changes
Copy link
Contributor
@OmarManzoor OmarManzoor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @glemaitre. Should we have some tests to check the preservation?

OmarManzoor
OmarManzoor approved these changes Jan 18, 2024
View reviewed changes
8000
Copy link
Contributor
@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @glemaitre

@OmarManzoor OmarManzoor merged commit fe5ba6f into scikit-learn:main Jan 18, 2024
glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Feb 10, 2024
@glemaitre
ENH TfidfTransformer perserves np.float32 dtype (scikit-learn#28136)
cabec86
@steppi steppi mentioned this pull request Jun 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

@OmarManzoor OmarManzoor OmarManzoor approved these changes

Assignees
No one assigned
Labels
module:feature_extraction
Projects
None yet
Milestone
No milestone
Development

Successfully merging 39ED this pull request may close these issues.
4 participants
@glemaitre @thomasjpfan @OmarManzoor @thebabush
0