8000 Adds __getitem__ to ColumnTransformer by thomasjpfan · Pull Request #27990 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

Adds __getitem__ to ColumnTransformer #27990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 27, 2023
Merged

Adds __getitem__ to ColumnTransformer #27990

merged 5 commits into from
Dec 27, 2023

Conversation

thomasjpfan
Copy link
Member
@thomasjpfan thomasjpfan commented Dec 20, 2023 •
edited
Loading

Reference Issues/PRs

Closes #15346

What does this implement/fix? Explain your changes.

This PR adds a __getitem__ to ColumnTransformer, which is the same as columntransformer.named_transformer_[...]. For now, the __getitem__ is restricted to fitted column transformers.

@github-actions GitHub Actions
Copy link
github-actions bot commented Dec 20, 2023 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: c96c618. Link to the linter CI: here

@thomasjpfan thomasjpfan mentioned this pull request Dec 21, 2023
Closed
adrinjalali
adrinjalali reviewed Dec 25, 2023
View reviewed changes
Copy link
Member
@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a test for when the key/subestimator name doesn't exist, and moving the changelog to 1.5, LGTM.

@adrinjalali adrinjalali merged commit 678e399 into scikit-learn:main Dec 27, 2023
glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Feb 10, 2024
@thomasjpfan @glemaitre
FEAT Adds __getitem__ to ColumnTransformer (scikit-learn#27990)
0f6f376 
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnothman jnothman jnothman approved these changes

@adrinjalali adrinjalali adrinjalali approved these changes

Assignees
No one assigned
Labels
module:compose
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add __getitem__ to ColumnTransformer?
4 participants
@thomasjpfan @jnothman @adrinjalali @glemaitre
0