8000 MAINT Remove deprecated support for int in boolean constraint by thomasjpfan · Pull Request #27924 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

MAINT Remove deprecated support for int in boolean constraint #27924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 11, 2023
Merged

MAINT Remove deprecated support for int in boolean constraint #27924

merged 2 commits into from
Dec 11, 2023

Conversation

thomasjpfan
Copy link
Member

This PR removes the deprecated support for ints in the boolean constraint.

@thomasjpfan thomasjpfan added this to the 1.4 milestone Dec 9, 2023
@thomasjpfan thomasjpfan added the Quick Review For PRs that are quick to review label Dec 9, 2023
@github-actions GitHub Actions
Copy link
github-actions bot commented Dec 9, 2023 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: dab53c5. Link to the linter CI: here

@thomasjpfan thomasjpfan changed the title MAINT Remove deprecation support for int in boolean constraint MAINT Remove deprecated support for int in boolean constraint Dec 9, 2023
ogrisel
ogrisel approved these changes Dec 10, 2023
Copy link
Member
@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lesteve
Copy link
Member
lesteve commented Dec 11, 2023

Merging, thanks!

@lesteve lesteve merged commit 0496f48 into scikit-learn:main Dec 11, 2023
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Feb 10, 2024
@thomasjpfan @glemaitre
MAINT Remove deprecated support for int in boolean constraint (scikit…
b1b4b0a 
…-learn#27924)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

Assignees
No one assigned
Labels
Blocker module:utils No Changelog Needed Quick Review For PRs that are quick to review
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasjpfan @lesteve @ogrisel
0