8000 DOC: Added drop down menus to `1.11` Ensemble Methods by linus-md · Pull Request #27915 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

DOC: Added drop down menus to 1.11 Ensemble Methods #27915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Feb 16, 2024
Merged

DOC: Added drop down menus to 1.11 Ensemble Methods #27915

merged 13 commits into from
Feb 16, 2024

Conversation

linus-md
Copy link
Contributor
@linus-md linus-md commented Dec 8, 2023 •
edited by ArturoAmorQ
Loading

Reference Issues/PRs

Addresses #26617.

What does this implement/fix? Explain your changes.

This adds drop down menus for all references.

@github-actions GitHub Actions
Copy link
github-actions bot commented Dec 8, 2023 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 2700111. Link to the linter CI: here

@ArturoAmorQ ArturoAmorQ mentioned this pull request Dec 8, 2023
Closed
54 tasks
@linus-md linus-md changed the title DOC: Added drop down menus to 1.11 DOC: Added drop down menus to 1.11 Ensemble Methods Dec 8, 2023
@linus-md
Copy link
Contributor Author

Hi @ArturoAmorQ do you have any feedback on this?

@ArturoAmorQ
Copy link
Member

Hi @linus-md as always thanks for your PRs and sorry for not giving feedback on this one before. Unfortunately the current implementation of dropdowns breaks the sphinx cross-reference system whenever they point inside a dropdown from the outside. The underlying issue is that the dropdown has to be unfolded for mozilla to access the reference.

In this case you will have to revert all of the references you are hiding in a dropdown (again, sorry about that). You can still use dropdowns to hide:

ArturoAmorQ
ArturoAmorQ approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member
@ArturoAmorQ ArturoAmorQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushing some commits and merging, thanks again for your work @linus-md!

@ArturoAmorQ ArturoAmorQ enabled auto-merge (squash) February 16, 2024 10:37
@ArturoAmorQ ArturoAmorQ merged commit 7a68c9b into scikit-learn:main Feb 16, 2024
@linus-md linus-md deleted the ensemble-doc branch February 16, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArturoAmorQ ArturoAmorQ ArturoAmorQ approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@linus-md @ArturoAmorQ
0