MAINT remove normalize parameter and subsequent clean-up #27855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rth @agramfort @maikia @jnothman pinging as possible reviewers, taken from #3020. |
|
The docstring of |
ogrisel
approved these changes
Dec 1, 2023
| 8000 | @@ -189,45 +109,51 @@ def make_dataset(X, y, sample_weight, random_state=None): | ||
| def _preprocess_data( | |||
| X, | |||
| y, | |||
| *, | |||
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
lesteve
reviewed
Dec 4, 2023
| @@ -415,36 +378,23 @@ def test_preprocess_data(global_random_seed): | |||
| X = rng.rand(n_samples, n_features) | |||
| y = rng.rand(n_samples) | |||
| expected_X_mean = np.mean(X, axis=0) | |||
| expected_X_scale = np.std(X, axis=0) * np.sqrt(X.shape[0]) | |||
| np.std(X, axis=0) * np.sqrt(X.shape[0]) | |||
There was a problem hiding this comment.
This line can be removed, right?
Suggested change
| np.std(X, axis=0) * np.sqrt(X.shape[0]) |
There was a problem hiding this comment.
I have pushed a commit removing this line and a similar one below
lesteve
reviewed
Dec 4, 2023
| @@ -586,43 +485,30 @@ def test_sparse_preprocess_data_offsets(global_random_seed, lil_container): | |||
| X = lil_container(X) | |||
| y = rng.rand(n_samples) | |||
| XA = X.toarray() | |||
| expected_X_scale = np.std(XA, axis=0) * np.sqrt(X.shape[0]) | |||
| np.std(XA, axis=0) * np.sqrt(X.shape[0]) | |||
There was a problem hiding this comment.
Suggested change
| np.std(XA, axis=0) * np.sqrt(X.shape[0]) |
|
Thanks @lesteve for removing the left over. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the parameter
normalizethat has been deprecating in OMP and least angle estimators.normalize=True_preprocess_datakeyword only to be more explicit in terms of parameter names.