-
-
Notifications
You must be signed in to change notification settings - Fork 25.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX Improve HDBSCAN Error Message when checking for connected components #27678
Conversation
- Separate connected components warning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is worth to add an entry in the changelog as a fix that clarify the error message.
…arn into hdbscan_warning_fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still LGTM. Need an additional reviewer to get it through.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @tataganesh
Reference Issues/PRs
Fixes #27436
What does this implement/fix? Explain your changes.
Currently, for HDBCAN, it is checked if the number of connected components of the mutual reachability graph is greater than one. If it is, an exception is raised stating that some elements in the distance matrix have less than
min_samples
neighbours. This exception is now split into two distinct exceptions -min_samples
neighbours