8000 FIX `_partial_fit_binary` passing classes only when classes are consumed by StefanieSenger · Pull Request #27464 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

FIX _partial_fit_binary passing classes only when classes are consumed #27464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

FIX _partial_fit_binary passing classes only when classes are consumed #27464

wants to merge 1 commit into from

Conversation

StefanieSenger
Copy link
Contributor

This PR fixes the issue that sklearn/multiclass._partial_fit_binary would pass classes to any estimator, even if they wouldn't consume it.

Thanks @adrinjalali for your help here.

@github-actions
Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: e285503. Link to the linter CI: here

@adrinjalali
Copy link
Member

seems like we don't actually need this fix: #27308 (comment)

But I would still pass classes as a keyword argument.

@StefanieSenger
Copy link
Contributor Author

@adrinjalali Nice, I will close this here then (and take care of the keyword argument in the other PR).

@StefanieSenger StefanieSenger deleted the _partial_fit_binary branch April 18, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StefanieSenger @adrinjalali
0