MNT SLEP6: raise NotImplementedError for meta-estimators not supporting metadata routing #27389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 tasks
|
CI is green now. |
|
This is ready for review now @glemaitre |
glemaitre
approved these changes
Sep 25, 2023
sklearn/utils/_metadata_requests.py
Outdated
| ) | ||
|
|
||
|
|
||
| class _RoutingNotSupported: |
There was a problem hiding this comment.
To be in line with other patter in the library.
Suggested change
| class _RoutingNotSupported: | |
| class _RoutingNotSupportedMixin: |
| def _raise_for_unsupported_routing(obj, method, **kwargs): | ||
| """Raise when metadata routing is enabled and metadata is passed. | ||
|
|
||
| This is used in meta-estimators which have not implemented metadata routing |
There was a problem hiding this comment.
I think that we could make it explicit that this is to be used in the desired function when metadata are already passed (e.g. sample_weight)
glemaitre
approved these changes
Sep 25, 2023
OmarManzoor
approved these changes
Sep 25, 2023
Co-authored-by: Omar Salman <omar.salman@arbisoft.com>
lesteve
pushed a commit
to lesteve/scikit-learn
that referenced
this pull request
Sep 28, 2023
…ng metadata routing (scikit-learn#27389)
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
…ng metadata routing (scikit-learn#27389)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes all meta-estimators for which we haven't implemented metadata routing yet to raise a
NotImplementedErrorif they're used in other meta-estimators (via raising this inget_metadata_routing).It also makes them raise in
fitif metadata routing is enabled and any metadata is passed to them.cc @glemaitre @OmarManzoor