8000 TST Extend tests for `scipy.sparse.*array` in ```sklearn/manifold/tests/test_isomap.py``` by brendanlu · Pull Request #27341 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

TST Extend tests for scipy.sparse.*array in sklearn/manifold/tests/test_isomap.py #27341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2023
Merged

TST Extend tests for scipy.sparse.*array in sklearn/manifold/tests/test_isomap.py #27341

merged 1 commit into from
Sep 13, 2023

Conversation

brendanlu
Copy link
Contributor

Reference Issues/PRs

Towards #27090

What does this implement/fix? Explain your changes.

Wrapped matrix output from sparse_rand in CSR_CONTAINERS

@github-actions
Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 15b886d. Link to the linter CI: here

@brendanlu brendanlu changed the title wrap sparse X in csr_container in test_isomap.py TST Extend tests for scipy.sparse.*array in sklearn/manifold/tests/test_isomap.py Sep 12, 2023
@glemaitre glemaitre mentioned this pull request Sep 13, 2023
Closed
@glemaitre glemaitre self-requested a review September 13, 2023 09:52
glemaitre
glemaitre approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member
@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @brendanlu.
Another easy one @OmarManzoor.

OmarManzoor
OmarManzoor approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor
@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @brendanlu

@OmarManzoor OmarManzoor merged commit 6ca15ea into scikit-learn:main Sep 13, 2023
@brendanlu brendanlu deleted the sparse1 branch September 14, 2023 01:10
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@brendanlu @REDVM
TST Extend tests for scipy.sparse.*array in ```sklearn/manifold/tes…
39bfb23 
…ts/test_isomap.py``` (scikit-learn#27341)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre glemai 5A90 tre approved these changes

@OmarManzoor OmarManzoor OmarManzoor approved these changes

Assignees
No one assigned
Labels
module:manifold No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brendanlu @glemaitre @OmarManzoor
0