8000 TST Extend tests for `scipy.sparse.*array` in `sklearn/utils/tests/test_mocking.py` by StefanieSenger · Pull Request #27319 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content
8000

TST Extend tests for scipy.sparse.*array in sklearn/utils/tests/test_mocking.py #27319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 12, 2023
Merged

TST Extend tests for scipy.sparse.*array in sklearn/utils/tests/test_mocking.py #27319

merged 2 commits into from
Sep 12, 2023

Conversation

StefanieSenger
Copy link
Contributor

Reference Issues/PRs

Towards #27090.

What does this implement/fix? Explain your changes.

This PR substitutes scipy sparse matrices with the scipy containers introduced in #27095 in the sklearn/utils/tests/test_mocking.py test file.

@github-actions
Copy link
github-actions bot commented Sep 8, 2023 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: eddfc0f. Link to the linter CI: here

@jjerphan jjerphan mentioned this pull request Sep 9, 2023
Closed
@glemaitre glemaitre self-requested a review September 11, 2023 16:56
glemaitre
glemaitre approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member
@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @StefanieSenger

OmarManzoor
OmarManzoor approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor
@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well.

@OmarManzoor OmarManzoor merged commit 9c6db99 into scikit-learn:main Sep 12, 2023
@StefanieSenger StefanieSenger deleted the sparse_array_test_mocking branch September 12, 2023 06:58
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@StefanieSenger @REDVM
TST Extend tests for scipy.sparse.*array in `sklearn/utils/tests/te…
7774f57 
…st_mocking.py` (scikit-learn#27319)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre glemaitre approved these changes

@OmarManzoor OmarManzoor OmarManzoor approved these changes

Assignees
No one assigned
Labels
module:utils No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StefanieSenger @glemaitre @OmarManzoor
0