-
-
Notifications
You must be signed in to change notification settings - Fork 25.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST Extend tests for scipy.sparse/*array
in sklearn/impute/tests/test_common
#27277
TST Extend tests for scipy.sparse/*array
in sklearn/impute/tests/test_common
#27277
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @Charlie-XIAO. Some minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @Charlie-XIAO
@glemaitre I've specified the format in |
Nice. Indeed, we need a changelog entry as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…est_common` (scikit-learn#27277) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Towards #27090.
I made the
.tocsr()
change becausescipy.sparse.hstack
would cause the output to becomecoo_matrix
when input is sparse array, andcoo_matrix
does not support slicing.