8000 TST Extend tests for `scipy.sparse/*array` in `sklearn/utils/tests/test_testing` by Charlie-XIAO · Pull Request #27276 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

TST Extend tests for scipy.sparse/*array in sklearn/utils/tests/test_testing #27276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 12, 2023
Merged

TST Extend tests for scipy.sparse/*array in sklearn/utils/tests/test_testing #27276

merged 6 commits into from
Sep 12, 2023
+46 −6

Conversation

Charlie-XIAO
Copy link
Contributor

Towards #27090.

I extended the _convert_container function a bit for the sparse arrays, please let me know if this is not necessary (in which case the tests for sparse arrays in test_convert_container need to be removed).

@github-actions
Copy link
github-actions bot commented Sep 3, 2023 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 46a58ba. Link to the linter CI: here

@lohitslohit
Copy link
Contributor

@Charlie-XIAO I am new to open source, Can you help me to fix the issue in #27275.

@jjerphan jjerphan mentioned this pull request Sep 3, 2023
Closed
@Charlie-XIAO Charlie-XIAO changed the title TST Extend tests for scipy.sparse/*array in sklearn/utils/tests/test_testing TST Extend tests for scipy.sparse/*array in sklearn/utils/tests/test_testing Sep 4, 2023
OmarManzoor
OmarManzoor approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor
@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Charlie-XIAO. I think it doesn't hurt to have the checks for sparse arrays as well.

glemaitre
glemaitre reviewed Sep 11, 2023
View reviewed changes
glemaitre
glemaitre reviewed Sep 12, 2023
View reviewed changes
glemaitre
glemaitre approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member
@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Charlie-XIAO

@glemaitre glemaitre merged commit 7dd3e4e into scikit-learn:main Sep 12, 2023
@Charlie-XIAO Charlie-XIAO deleted the tst_sp_testing branch September 14, 2023 04:00
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@Charlie-XIAO @REDVM
TST Extend tests for scipy.sparse/*array in `sklearn/utils/tests/te…
be8844f 
…st_testing` (scikit-learn#27276)
@Charlie-XIAO Charlie-XIAO mentioned this pull request Feb 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre glemaitre approved these changes

@OmarManzoor OmarManzoor OmarManzoor approved these changes

Assignees
No one assigned
Labels
module:utils No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Charlie-XIAO @lohitslohit @glemaitre @OmarManzoor
0