10000 TST Extend tests for `scipy.sparse.*array` in `sklearn/tests/test_calibration.py` by BHolmes92 · Pull Request #27257 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

TST Extend tests for scipy.sparse.*array in sklearn/tests/test_calibration.py #27257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 12, 2023
Merged

TST Extend tests for scipy.sparse.*array in sklearn/tests/test_calibration.py #27257

merged 4 commits into from
Sep 12, 2023
+7 −5

Conversation

BHolmes92
Copy link
Contributor

Towards #27090.

@github-actions
Copy link
github-actions bot commented Aug 31, 2023 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 71c5580. Link to the linter CI: here

@jjerphan jjerphan mentioned this pull request Aug 31, 2023
Closed
OmarManzoor
OmarManzoor reviewed Sep 12, 2023
View reviewed changes
Copy link
Contributor
@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @BHolmes92.

@glemaitre glemaitre self-requested a review September 12, 2023 08:40
@glemaitre @OmarManzoor
Apply suggestions from code review
be9b574 
Co-authored-by: Omar Salman <omar.salman@arbisoft.com>
glemaitre
glemaitre approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member
@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Applied the changes proposed by @OmarManzoor.
Merging once the CIs are passing.

OmarManzoor
OmarManzoor approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor
@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @BHolmes92 , @glemaitre

@glemaitre glemaitre merged commit dafef82 into scikit-learn:main Sep 12, 2023
@glemaitre
Copy link
Member

The linting CI got lost but this looks good. Merging. Thanks @BHolmes92

REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@BHolmes92 @glemaitre
@OmarManzoor @REDVM
TST Extend tests for scipy.sparse.*array in `sklearn/tests/test_cal…
879535e 
…ibration.py` (scikit-learn#27257)

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Omar Salman <omar.salman@arbisoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre glemaitre approved these changes

@OmarManzoor OmarManzoor OmarManzoor approved these changes

Assignees
No one assigned
Labels
No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BHolmes92 @glemaitre @OmarManzoor
0