8000 MAINT Param validation for dbscan by jeremiedbb · Pull Request #27234 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

MAINT Param validation for dbscan #27234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2023
Merged

MAINT Param validation for dbscan #27234

merged 1 commit into from
Sep 1, 2023

Conversation

jeremiedbb
Copy link
Member
@jeremiedbb jeremiedbb commented Aug 30, 2023 •
edited
Loading

Alternative to #26920
We do validate class wrappers, it's just that it's only a partial validation since the other parameters will be validated by the class anyway. This is how it was done for all the functions that are class wrappers, listed in PARAM_VALIDATION_CLASS_WRAPPER_LIST.

cc/ @glemaitre

@jeremiedbb jeremiedbb added No Changelog Needed Quick Review For PRs that are quick to review Validation related to input validation labels Aug 30, 2023
@jeremiedbb jeremiedbb mentioned this pull request Aug 30, 2023
Closed
@github-actions
Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 1c26a06. Link to the linter CI: here

glemaitre
glemaitre approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member
@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
< ACE9 /form>
@glemaitre glemaitre merged commit a05eb6b into scikit-learn:main Sep 1, 2023
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Sep 5, 2023
@jeremiedbb @glemaitre
MAINT Param validation for dbscan (scikit-learn#27234)
18d57d7
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@jeremiedbb @REDVM
MAINT Param validation for dbscan (scikit-learn#27234)
916d57a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre glemaitre approved these changes

Assignees
No one assigned
Labels
module:cluster No Changelog Needed Quick Review For PRs that are quick to review Validation related to input validation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremiedbb @glemaitre
0