8000 TST Extend tests for `scipy.sparse/*array` in `sklearn/linear_model/tests/test_base` by Charlie-XIAO · Pull Request #27225 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

TST Extend tests for scipy.sparse/*array in sklearn/linear_model/tests/test_base #27225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 13, 2023
Merged

TST Extend tests for scipy.sparse/*array in sklearn/linear_model/tests/test_base #27225

merged 8 commits into from
Sep 13, 2023

Conversation

Charlie-XIAO
Copy link
Contributor

Towards #27090.

@github-actions
Copy link
github-actions bot commented Aug 30, 2023 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 3cbdfc6. Link to the linter CI: here

@jjerphan jjerphan mentioned this pull request Aug 31, 2023
Closed
OmarManzoor
OmarManzoor reviewed Sep 1, 2023
View reviewed changes
Copy link
Contributor
@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Charlie-XIAO

OmarManzoor
OmarManzoor approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor
@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glemaitre glemaitre self-requested a review September 13, 2023 12:57
glemaitre
glemaitre approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member
@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Charlie-XIAO.

I just spotted somewhere that we were using a LIL matrix and make sure that we tested with LIL arrays as well.

@glemaitre glemaitre enabled auto-merge (squash) September 13, 2023 13:04
auto-merge was automatically disabled September 13, 2023 14:45

Head branch was pushed to by a user without write access

@Charlie-XIAO
Copy link
Contributor Author

@glemaitre Seems that there are some deprecated .A causing CI to fail. I tried to fix it so auto-merge is disabled now. Let's see if this time it works.

@glemaitre
Copy link
Member

Thanks @Charlie-XIAO. It is passing now so merging.
Thanks for fixing those.

@glemaitre glemaitre merged commit b60ee07 into scikit-learn:main Sep 13, 2023
@Charlie-XIAO Charlie-XIAO deleted the tst_sp_linmod_base branch September 14, 2023 03:58
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@Charlie-XIAO @glemaitre @REDVM
TST Extend tests for scipy.sparse/*array in `sklearn/linear_model/t…
faf9bdb 
…ests/test_base` (scikit-learn#27225)

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre glemaitre approved these changes

@OmarManzoor OmarManzoor OmarManzoor approved these changes

Assignees
No one assigned
Labels
module:linear_model No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Charlie-XIAO @glemaitre @OmarManzoor
0