8000 TST Extend tests for `scipy.sparse.*array` in `sklearn/manifold/tests/test_t_sne.py` by Tialo · Pull Request #27221 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

TST Extend tests for scipy.sparse.*array in sklearn/manifold/tests/test_t_sne.py #27221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 13, 2023
Merged

TST Extend tests for scipy.sparse.*array in sklearn/manifold/tests/test_t_sne.py #27221

merged 2 commits into from
Sep 13, 2023

Conversation

Tialo
Copy link
Contributor
@Tialo Tialo commented Aug 30, 2023

Reference Issues/PRs

Towards #27090.

What does this implement/fix? Explain your changes.

Any other comments?

If there is the better way to parameterise test test_bad_precomputed_distances, I will fix it.

@github-actions
Copy link
github-actions bot commented Aug 30, 2023 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: d01046d. Link to the linter CI: here

@jjerphan jjerphan mentioned this pull request Aug 31, 2023
Closed
OmarManzoor
OmarManzoor approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor
@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Tialo

@glemaitre glemaitre self-requested a review September 13, 2023 13:12
glemaitre
glemaitre approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member
@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just parametrize a couple of occurrences that locally converted or imported sparse matrices.

@glemaitre
Copy link
Member

Enabling the auto-merge

@glemaitre glemaitre merged commit 0169bde into scikit-learn:main Sep 13, 2023
@Tialo Tialo deleted the tests/test_t_sne branch September 13, 2023 17:37
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@Tialo @glemaitre @REDVM
TST Extend tests for scipy.sparse.*array in `sklearn/manifold/tests…
b806472 
…/test_t_sne.py` (scikit-learn#27221)

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre glemaitre approved these changes

@OmarManzoor OmarManzoor OmarManzoor approved these changes

Assignees
No one assigned
Labels
module:manifold No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tialo @glemaitre @OmarManzoor
0