8000 TST Extend tests for `scipy.sparse.*array` in `sklearn/linear_model/tests/test_sag.py` by Tialo · Pull Request #27206 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

TST Extend tests for scipy.sparse.*array in sklearn/linear_model/tests/test_sag.py #27206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2023
Merged

TST Extend tests for scipy.sparse.*array in sklearn/linear_model/tests/test_sag.py #27206

merged 1 commit into from
Sep 13, 2023

Conversation

Tialo
Copy link
Contributor
@Tialo Tialo commented Aug 29, 2023

Reference Issues/PRs

Towards #27090.

What does this implement/fix? Explain your changes.

Any other comments?

I noticed some comments in code that should be undone when #4710 will be done.
https://github.com/scikit-learn/scikit-learn/blob/main/sklearn/linear_model/tests/test_sag.py#L496

@github-actions
Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 639ce0e. Link to the linter CI: here

work-mohit
work-mohit approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor
@work-mohit work-mohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

OmarManzoor
OmarManzoor approved these changes 8000 Aug 30, 2023
View reviewed changes
Copy link
Contributor
@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Tialo

@jjerphan jjerphan mentioned this pull request Aug 30, 2023
Closed
@glemaitre glemaitre self-requested a review September 13, 2023 20:09
glemaitre
glemaitre approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member
@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Tialo
Merging.

@glemaitre glemaitre merged commit 1eb35b5 into scikit-learn:main Sep 13, 2023
@Tialo Tialo deleted the tests/test_sag branch September 13, 2023 20:23
@Tialo
Copy link
Contributor Author
Tialo commented Sep 13, 2023

Take a glance at the comment which I mentioned in PR title message @glemaitre

@glemaitre
Copy link
Member

@Tialo What do you mean? I don't think I get your comment? Is it about #4710?

@Tialo
Copy link
Contributor Author
Tialo commented Sep 13, 2023

@glemaitre Yes, it says that those lines should be uncommented, as #4710 will be merged, so I thought maybe it is time.

@Tialo
Copy link
Contributor Author
Tialo commented Sep 13, 2023

*not merged, but resolved

@glemaitre
Copy link
Member

We could open a PR and try to see if it pass.
We could also investigate if it does not pass :)

@Tialo
Copy link
Contributor Author
Tialo commented Sep 13, 2023

I will work on it tomorrow, if it is okay @glemaitre

@glemaitre
Copy link
Member

I will work on it tomorrow, if it is okay @glemaitre

Whenever you fill like it :). You can ping my GitHub handle such that it falls under my radar.

REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@Tialo @REDVM
TST Extend tests for scipy.sparse.*array in `sklearn/linear_model/t…
2d93457 
…ests/test_sag.py` (scikit-learn#27206)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre glemaitre approved these changes

@OmarManzoor OmarManzoor OmarManzoor approved these changes

@work-mohit work-mohit work-mohit approved these changes

Assignees
No one assigned
Labels
module:linear_model No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tialo @glemaitre @OmarManzoor @work-mohit
0