10000 TST Extend tests for `scipy.sparse.*array` in `sklearn/feature_selection/tests/test_base.py` by work-mohit · Pull Request #27175 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

TST Extend tests for scipy.sparse.*array in sklearn/feature_selection/tests/test_base.py #27175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 11, 2023
Merged

TST Extend tests for scipy.sparse.*array in sklearn/feature_selection/tests/test_base.py #27175

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
393768b
extended the test cases for sparse arrays
work-mohit Aug 26, 2023
af3448e
extended the test cases of test_base.py
work-mohit Aug 26, 2023
c36b399
Merge branch 'main' into fix/feature_selection/tests/test_base.py
work-mohit Aug 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions sklearn/feature_selection/tests/test_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import numpy as np
import pytest
from numpy.testing import assert_array_equal
from scipy import sparse as sp

from sklearn.base import BaseEstimator
from sklearn.feature_selection._base import SelectorMixin
from sklearn.utils.fixes import CSC_CONTAINERS


class StepSelector(SelectorMixin, BaseEstimator):
Expand Down Expand Up @@ -60,17 +60,18 @@ def test_transform_dense():
sel.transform(np.array([[1], [2]]))


def test_transform_sparse():
sparse = sp.csc_matrix
@pytest.mark.parametrize("csc_container", CSC_CONTAINERS)
def test_transform_sparse(csc_container):
X_sp = csc_container(X)
sel = StepSelector()
Xt_actual = sel.fit(sparse(X)).transform(sparse(X))
Xt_actual2 = sel.fit_transform(sparse(X))
Xt_actual = sel.fit(X_sp).transform(X_sp)
Xt_actual2 = sel.fit_transform(X_sp)
assert_array_equal(Xt, Xt_actual.toarray())
assert_array_equal(Xt, Xt_actual2.toarray())

# Check dtype matches
assert np.int32 == sel.transform(sparse(X).astype(np.int32)).dtype
assert np.float32 == sel.transform(sparse(X).astype(np.float32)).dtype
assert np.int32 == sel.transform(X_sp.astype(np.int32)).dtype
assert np.float32 == sel.transform(X_sp.astype(np.float32)).dtype

# Check wrong shape raises error
with pytest.raises(ValueError):
Expand All @@ -95,15 +96,17 @@ def test_inverse_transform_dense():
sel.inverse_transform(np.array([[1], [2]]))


def test_inverse_transform_sparse():
sparse = sp.csc_matrix
@pytest.mark.parametrize("csc_container", CSC_CONTAINERS)
def test_inverse_transform_sparse(csc_container):
X_sp = csc_container(X)
Xt_sp = csc_container(Xt)
sel = StepSelector()
Xinv_actual = sel.fit(sparse(X)).inverse_transform(sparse(Xt))
Xinv_actual = sel.fit(X_sp).inverse_transform(Xt_sp)
assert_array_equal(Xinv, Xinv_actual.toarray())

# Check dtype matches
assert np.int32 == sel.inverse_transform(sparse(Xt).astype(np.int32)).dtype
assert np.float32 == sel.inverse_transform(sparse(Xt).astype(np.float32)).dtype
assert np.int32 == sel.inverse_transform(Xt_sp.astype(np.int32)).dtype
assert np.float32 == sel.inverse_transform(Xt_sp.astype(np.float32)).dtype

# Check wrong shape raises error
with pytest.raises(ValueError):
Expand Down
0