8000 TST Extend tests for `scipy.sparse.*array` in `sklearn/feature_selection/tests/test_mutual_info.py` by brendanlu · Pull Request #27173 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

TST Extend tests for scipy.sparse.*array in sklearn/feature_selection/tests/test_mutual_info.py #27173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 11, 2023
Merged

TST Extend tests for scipy.sparse.*array in sklearn/feature_selection/tests/test_mutual_info.py #27173

merged 6 commits into from
Sep 11, 2023

Conversation

brendanlu
Copy link
Contributor

Reference Issues/PRs

Towards #27090.

What does this implement/fix? Explain your changes.

Decorate test_mutual_info_options to conditionally test sparse array.

@github-actions
Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 2a4022f. Link to the linter CI: here

work-mohit
work-mohit approved these changes Aug 26, 2023
View reviewed changes
Copy link
Contributor
@work-mohit work-mohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good work @brendanlu

@jjerphan jjerphan mentioned this pull request Aug 27, 2023
Closed
OmarManzoor
OmarManzoor approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor
@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @brendanlu

ogrisel
ogrisel approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member
@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ogrisel ogrisel merged commit 8d48624 into scikit-learn:main Sep 11, 2023
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@brendanlu @glemaitre @REDVM
TST Extend tests for scipy.sparse.*array in `sklearn/feature_select…
e2904c7 
…ion/tests/test_mutual_info.py` (scikit-learn#27173)

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@OmarManzoor OmarManzoor OmarManzoor approved these changes

@work-mohit work-mohit work-mohit approved these changes

Assignees
No one assigned
Labels
module:feature_selection No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@brendanlu @ogrisel @OmarManzoor @work-mohit @jjerphan @glemaitre
0