8000 TST Extend tests for `scipy.sparse.*array` in `sklearn/tests/test_multioutput.py` by naman1608 · Pull Request #27171 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

TST Extend tests for scipy.sparse.*array in sklearn/tests/test_multioutput.py #27171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 28, 2023
Merged

TST Extend tests for scipy.sparse.*array in sklearn/tests/test_multioutput.py #27171

merged 2 commits into from
Aug 28, 2023

Conversation

naman1608
Copy link
Contributor

Reference Issues/PRs

Towards #27090.

What does this implement/fix? Explain your changes.

Any other comments?

@github-actions
Copy link
github-actions bot commented Aug 25, 2023 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: a60c104. Link to the linter CI: here

work-mohit
work-mohit approved these changes Aug 26, 2023
View reviewed changes
Copy link
Contributor
@work-mohit work-mohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !
And thanks, your code helped me in fixing some error.

@jjerphan jjerphan mentioned this pull request Aug 27, 2023
Closed
@jjerphan jjerphan added No Changelog Needed module:test-suite everything related to our tests labels Aug 27, 2023
ogrisel
ogrisel approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member
@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

OmarManzoor
OmarManzoor approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor
@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @naman1608

@OmarManzoor OmarManzoor merged commit dea72cc into scikit-learn:main Aug 28, 2023
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Aug 29, 2023
@naman1608 @glemaitre
TST Extend tests for scipy.sparse.*array in `sklearn/tests/test_mul…
8ca1ad6 
…tioutput.py` (scikit-learn#27171)
@glemaitre
Copy link
Member
glemaitre commented Sep 11, 2023 •
edited
Loading

There is actually a bug in SciPy:

/usr/share/miniconda/envs/testvenv/lib/python3.11/site-packages/scipy/sparse/_base.py:251: in __iter__
    yield self[r, :]
        r          = 0
        self       = <50x100 sparse array of type '<class 'numpy.float64'>'
	with 5000 stored elements in Dictionary Of Keys format>
/usr/share/miniconda/envs/testvenv/lib/python3.11/site-packages/scipy/sparse/_index.py:53: in __getitem__
    self._raise_on_1d_array_slice()
        col        = slice(None, None, None)
        key        = (0, slice(None, None, None))
        row        = 0
        self       = <50x100 sparse array of type '<class 'numpy.float64'>'
	with 5000 stored elements in Dictionary Of Keys format>

We should absolutely trigger the CI with [scipy-dev] tag to test against the nightly.

@glemaitre glemaitre mentioned this pull request Sep 11, 2023
Merged
@ogrisel
Copy link
Member
ogrisel commented Sep 11, 2023

@glemaitre do you have a link to the full traceback?

@glemaitre
Copy link
Member

Here is the traceback: https://dev.azure.com/scikit-learn/scikit-learn/_build/results?buildId=58833&view=logs&jobId=dfe99b15-50db-5d7b-b1e9-4105c42527cf&j=dfe99b15-50db-5d7b-b1e9-4105c42527cf&t=ef785ae2-496b-5b02-9f0e-07a6c3ab3081

REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@naman1608 @REDVM
TST Extend tests for scipy.sparse.*array in `sklearn/tests/test_mul…
bbe2453 
…tioutput.py` (scikit-learn#27171)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@OmarManzoor OmarManzoor OmarManzoor approved these changes

@work-mohit work-mohit work-mohit approved these changes

Assignees
No one assigned
Labels
module:test-suite everything related to our tests No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@naman1608 @glemaitre @ogrisel @OmarManzoor @work-mohit @jjerphan
0