8000 TST Extend tests for `scipy.sparse.*array` in `sklearn/decomposition/tests/test_online_lda.py` by work-mohit · Pull Request #27144 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

TST Extend tests for scipy.sparse.*array in sklearn/decomposition/tests/test_online_lda.py #27144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 24, 2023
Merged

TST Extend tests for scipy.sparse.*array in sklearn/decomposition/tests/test_online_lda.py #27144

merged 5 commits into from
Aug 24, 2023
+56 −35

Conversation

work-mohit
Copy link
Contributor

Towards #27090

@github-actions
Copy link
github-actions bot commented Aug 23, 2023 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: a1c176c. Link to the linter CI: here

@ogrisel ogrisel mentioned this pull request Aug 24, 2023
Closed
ogrisel
ogrisel approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member
@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, just a suggestion to rename the helper function: _build_sparse_mtx to _build_sparse_array.

OmarManzoor
OmarManzoor approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor
@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @work-mohit

@OmarManzoor OmarManzoor merged commit 462a6d3 into scikit-learn:main Aug 24, 2023
@work-mohit work-mohit deleted the fix/tst/decomposition/tests/test_online_lda.py branch August 24, 2023 10:15
akaashpatelmns pushed a commit to akaashp2000/scikit-learn that referenced this pull request Aug 25, 2023
@work-mohit @akaashpatelmns
TST Extend tests for scipy.sparse.*array in `sklearn/decomposition/…
1deaf5f 
…tests/test_online_lda.py` (scikit-learn#27144)
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Aug 29, 2023
@work-mohit @glemaitre
TST Extend tests for scipy.sparse.*array in `sklearn/decomposition/…
753c2ec 
…tests/test_online_lda.py` (scikit-learn#27144)
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@work-mohit @REDVM
TST Extend tests for scipy.sparse.*array in `sklearn/decomposition/…
7d3b853 
…tests/test_online_lda.py` (scikit-learn#27144)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@OmarManzoor OmarManzoor OmarManzoor approved these changes

Assignees
No one assigned
Labels
module:decomposition No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@work-mohit @ogrisel @OmarManzoor
0