8000 TST Extend tests for `scipy.sparse.*array` in `sklearn/linear_model/tests/test_linear_loss.py` by bncer · Pull Request #27133 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

TST Extend tests for scipy.sparse.*array in sklearn/linear_model/tests/test_linear_loss.py #27133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2023
Merged

TST Extend tests for scipy.sparse.*array in sklearn/linear_model/tests/test_linear_loss.py #27133

merged 1 commit into from
Aug 23, 2023

Conversation

bncer
Copy link
Contributor
@bncer bncer commented Aug 22, 2023

Reference Issues/PRs

Towards #27090.

What does this implement/fix? Explain your changes.

This PR adds test cases of scipy's sparse array into sklearn/linear_model/tests/test_linear_loss.py file

Any other comments?

@bncer
TST add sparse array to linear loss
c86faf7 
Signed-off-by: Nurseit Kamchyev <bncer.ml@gmail.com>
@github-actions
Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: c86faf7. Link to the linter CI: here

@jjerphan jjerphan mentioned this pull request Aug 22, 2023
Closed
OmarManzoor
OmarManzoor approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor
@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @bncer

ogrisel
ogrisel approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member
@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well.

@ogrisel ogrisel merged commit 7ad7090 into scikit-learn:main Aug 23, 2023
@bncer bncer deleted the tst-linear-loss branch August 23, 2023 17:10
akaashpatelmns pushed a commit to akaashp2000/scikit-learn that referenced this pull request Aug 25, 2023
@bncer @akaashpatelmns
TST Extend tests for scipy.sparse.*array in `sklearn/linear_model/t…
dd18858 
…ests/test_linear_loss.py` (scikit-learn#27133)

Signed-off-by: Nurseit Kamchyev <bncer.ml@gmail.com>
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Aug 29, 2023
@bncer @glemaitre
TST Extend tests for scipy.sparse.*array in `sklearn/linear_model/t…
9f42293 
…ests/test_linear_loss.py` (scikit-learn#27133)

Signed-off-by: Nurseit Kamchyev <bncer.ml@gmail.com>
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@bncer @REDVM
TST Extend tests for scipy.sparse.*array in `sklearn/linear_model/t…
9ce4e7d 
…ests/test_linear_loss.py` (scikit-learn#27133)

Signed-off-by: Nurseit Kamchyev <bncer.ml@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@OmarManzoor OmarManzoor OmarManzoor approved these changes

Assignees
No one assigned
Labels
module:linear_model No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bncer @ogrisel @OmarManzoor
0