8000 TST Extend tests for `scipy.sparse.*array` in `sklearn/cluster/tests/test_hdbscan.py` by andyscanzio · Pull Request #27116 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

TST Extend tests for scipy.sparse.*array in sklearn/cluster/tests/test_hdbscan.py #27116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2023
Merged

TST Extend tests for scipy.sparse.*array in sklearn/cluster/tests/test_hdbscan.py #27116

merged 1 commit into from
Aug 21, 2023

Conversation

andyscanzio
Copy link
Contributor

Reference Issues/PRs

Towards #27090.

What does this implement/fix? Explain your changes.

This PR introduces sparse containers' list conditionnaly to the version of SciPy so that we can extend tests as part of #27090.

Any other comments?

@github-actions
Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 5b9295f. Link to the linter CI: here

@andyscanzio andyscanzio changed the title TST Add and adapt test parametrization TST Extend tests for scipy.sparse.*array in sklearn/cluster/tests/test_hdbscan.py Aug 20, 2023
OmarManzoor
OmarManzoor approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor
@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andyscanzio. LGTM!

ogrisel
ogrisel approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member
@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well. Thanks for the PR!

@ogrisel ogrisel merged commit f519705 into scikit-learn:main Aug 21, 2023
@ogrisel ogrisel mentioned this pull request Aug 21, 2023
Closed
@andyscanzio andyscanzio deleted the fix-26418 branch August 21, 2023 17:44
TamaraAtanasoska pushed a commit to TamaraAtanasoska/scikit-learn that referenced this pull request Aug 21, 2023
@andyscanzio @TamaraAtanasoska
TST Extend tests for scipy.sparse.*array in `sklearn/cluster/tests/…
65d4cce 
…test_hdbscan.py` (scikit-learn#27116)
akaashpatelmns pushed a commit to akaashp2000/scikit-learn that referenced this pull request Aug 25, 2023
@andyscanzio @akaashpatelmns
TST Extend tests for scipy.sparse.*array in `sklearn/cluster/tests/…
3877fa0 
…test_hdbscan.py` (scikit-learn#27116)
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@andyscanzio @REDVM
TST Extend tests for scipy.sparse.*array in `sklearn/cluster/tests/…
0f9a9ce 
…test_hdbscan.py` (scikit-learn#27116)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@OmarManzoor OmarManzoor OmarManzoor approved these changes

Assignees
No one assigned
Labels
module:cluster No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andyscanzio @ogrisel @OmarManzoor
0