8000 TST Extend tests for `scipy.sparse.*array` in `sklearn/cluster/tests/test_hierarchical.py` by vvkrddy · Pull Request #27101 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

TST Extend tests for scipy.sparse.*array in sklearn/cluster/tests/test_hierarchical.py #27101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 28, 2023
Merged

TST Extend tests for scipy.sparse.*array in sklearn/cluster/tests/test_hierarchical.py #27101

merged 10 commits into from
Aug 28, 2023

Conversation

vvkrddy
Copy link
Contributor
@vvkrddy vvkrddy commented Aug 18, 2023

Reference Issues/PRs

Towards #27090.

@github-actions
Copy link
github-actions bot commented Aug 18, 2023 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 0cbf9ae. Link to the linter CI: here

@jjerphan jjerphan mentioned this pull request Aug 18, 2023
Closed
OmarManzoor
OmarManzoor reviewed Aug 22, 2023
View reviewed changes
Copy link
Contributor
@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @vvkrddy. Here are a few comments.

OmarManzoor
OmarManzoor reviewed Aug 25, 2023
View reviewed changes
OmarManzoor
OmarManzoor reviewed Aug 25, 2023
View reviewed changes
@ogrisel
Copy link
Member
ogrisel commented Aug 25, 2023

@vvkrddy could you please fix the linting issues by following the instructions in the comments by the linting bot?

ogrisel
ogrisel approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member
@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ogrisel ogrisel enabled auto-merge (squash) August 28, 2023 09:13
OmarManzoor
OmarManzoor approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor
@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @vvkrddy

@ogrisel ogrisel merged commit 8e14bd0 into scikit-learn:main Aug 28, 2023
@vvkrddy vvkrddy deleted the branch1 branch August 28, 2023 09:44
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Aug 29, 2023
@vvkrddy @glemaitre
TST Extend tests for scipy.sparse.*array in `sklearn/cluster/tests/…
ade8ab5 
…test_hierarchical.py` (scikit-learn#27101)
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@vvkrddy @REDVM
TST Extend tests for scipy.sparse.*array in `sklearn/cluster/tests/…
dcfea42 
…test_hierarchical.py` (scikit-learn#27101)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@OmarManzoor OmarManzoor OmarManzoor approved these changes

Assignees
No one assigned
Labels
module:cluster No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vvkrddy @ogrisel @OmarManzoor
0