10000 TST Extend tests for `scipy.sparse.*array` in `sklearn/cluster/tests/test_bisect_k_means.py` by Kislovskiy · Pull Request #27099 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

TST Extend tests for scipy.sparse.*array in sklearn/cluster/tests/test_bisect_k_means.py #27099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 18, 2023
Merged

TST Extend tests for scipy.sparse.*array in sklearn/cluster/tests/test_bisect_k_means.py #27099

merged 4 commits into from
Aug 18, 2023

Conversation

Kislovskiy
Copy link
Contributor

Reference Issues/PRs

Towards #27090.

What does this implement/fix? Explain your changes.

Any other comments?

@jjerphan jjerphan mentioned this pull request Aug 18, 2023
Closed
@Kislovskiy Kislovskiy changed the title TST Extend tests for scipy.sparse.*array in scikit-learn/sklearn/cluster/tests/test_bisect_k_means.py TST Extend tests for scipy.sparse.*array in sklearn/cluster/tests/test_bisect_k_means.py Aug 18, 2023
@github-actions
Copy link
github-actions bot commented Aug 18, 2023 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: cb75060. Link to the linter CI: here

@Kislovskiy Kislovskiy marked this pull request as ready for review August 18, 2023 12:00
@Kislovskiy Kislovskiy changed the title TST Extend tests for scipy.sparse.*array in sklearn/cluster/tests/test_bisect_k_means.py TST Extend tests for scipy.sparse.*array in sklearn/cluster/tests/test_bisect_k_means.py Aug 18, 2023
@ogrisel ogrisel mentioned this pull request Aug 18, 2023
Merged
jjerphan
jjerphan approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member
@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM given a green CI.

ogrisel
ogrisel reviewed Aug 18, 2023
View reviewed changes
ogrisel
ogrisel approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member
@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the CI is green, then LGTM as well!

@ogrisel ogrisel enabled auto-merge (squash) August 18, 2023 14:54
@ogrisel ogrisel merged commit 84273d8 into scikit-learn:main Aug 18, 2023
@ogrisel
Copy link
Member
ogrisel commented Aug 19, 2023

Merged. Thanks @Kislovskiy for the fix!

@Kislovskiy Kislovskiy deleted the towards-27090-test_bisect_k_means.py branch August 19, 2023 19:19
TamaraAtanasoska pushed a commit to TamaraAtanasoska/scikit-learn that referenced this pull request Aug 21, 2023
@Kislovskiy @ogrisel @TamaraAtanasoska
TST Extend tests for scipy.sparse.*array in `sklearn/cluster/tests/…
5edc3db 
…test_bisect_k_means.py` (scikit-learn#27099)

Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
akaashpatelmns pushed a commit to akaashp2000/scikit-learn that referenced this pull request Aug 25, 2023
@Kislovskiy @ogrisel @akaashpatelmns
TST Extend tests for scipy.sparse.*array in `sklearn/cluster/tests/…
03c0e96 
…test_bisect_k_means.py` (scikit-learn#27099)

Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@Kislovskiy @ogrisel @REDVM
TST Extend tests for scipy.sparse.*array in `sklearn/cluster/tests/…
283baa7 
…test_bisect_k_means.py` (scikit-learn#27099)

Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@jjerphan jjerphan jjerphan approved these changes

Assignees
No one assigned
Labels
module:cluster No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kislovskiy @ogrisel @jjerphan
0