8000 TST Extend tests for `scipy.sparse.*array` in `sklearn/cluster/tests/test_bicluster.py` by Kislovskiy · Pull Request #27093 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

TST Extend tests for scipy.sparse.*array in sklearn/cluster/tests/test_bicluster.py #27093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 18, 2023
Merged

Conversation

Kislovskiy
Copy link
Contributor
@Kislovskiy Kislovskiy commented Aug 18, 2023

Reference Issues/PRs

Towards #27090.

What does this implement/fix? Explain your changes.

Any other comments?

@github-actions
Copy link
github-actions bot commented Aug 18, 2023

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 24e36bd. Link to the linter CI: here

@Kislovskiy Kislovskiy changed the title FIX-26418 Use both csr_matrix, csr_array TEST Use both csr_matrix, csr_array for sklearn/cluster/tests/test_bicluster.py Aug 18, 2023
@Kislovskiy Kislovskiy changed the title TEST Use both csr_matrix, csr_array for sklearn/cluster/tests/test_bicluster.py TST Extend tests for scipy.sparse.*array in sklearn/cluster/tests/test_bicluster.py Aug 18, 2023
@jjerphan jjerphan changed the title TST Extend tests for scipy.sparse.*array in sklearn/cluster/tests/test_bicluster.py TST Extend tests for scipy.sparse.*array in sklearn/cluster/tests/test_bicluster.py Aug 18, 2023
@Kislovskiy Kislovskiy marked this pull request as ready for review August 18, 2023 10:07
Copy link
Member
@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM given a green CI.

Thank you, @Kislovskiy! 🙂

Copy link
Member
@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming CI is green, LGTM as well. Thanks for the contrib!

@ogrisel ogrisel enabled auto-merge (squash) August 18, 2023 11:47
@ogrisel ogrisel merged commit 2858261 into scikit-learn:main Aug 18, 2023
TamaraAtanasoska pushed a commit to TamaraAtanasoska/scikit-learn that referenced this pull request Aug 21, 2023
…test_bicluster.py` (scikit-learn#27093)

Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
akaashpatelmns pushed a commit to akaashp2000/scikit-learn that referenced this pull request Aug 25, 2023
…test_bicluster.py` (scikit-learn#27093)

Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
…test_bicluster.py` (scikit-learn#27093)

Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0