DOC Documents fixed to increase speed by removing for loop #27066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f plot remove for loop
remove for loop
thomasjpfan
reviewed
Aug 14, 2023
There was a problem hiding this comment.
Thank you for the PR @narendrasinghdangi ! I am okay with the proposed change.
| @@ -232,7 +232,7 @@ def plot_n_features_influence(percentiles, percentile): | |||
| fig, ax1 = plt.subplots(figsize=(10, 6)) | |||
| colors = ["r", "g", "b"] | |||
| for i, cls_name in enumerate(percentiles.keys()): | |||
| x = np.array(sorted([n for n in percentiles[cls_name].keys()])) | |||
| x = np.array(sorted(list(percentiles[cls_name].keys()))) | |||
There was a problem hiding this comment.
In this case, I do not think the list is required either:
Suggested change
| x = np.array(sorted(list(percentiles[cls_name].keys()))) | |
| x = np.array(sorted(percentiles[cls_name].keys())) |
There was a problem hiding this comment.
yes, you are right i have changed the file now you can merge now to main branch
thank you
|
Thank you for your suggestion i have changed the file now. |
TamaraAtanasoska
pushed a commit
to TamaraAtanasoska/scikit-learn
that referenced
this pull request
Aug 21, 2023
akaashpatelmns
pushed a commit
to akaashp2000/scikit-learn
that referenced
this pull request
Aug 25, 2023
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Sep 18, 2023
jeremiedbb
pushed a commit
that referenced
this pull request
Sep 20, 2023
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Closes #27065
What does this implement/fix? Explain your changes.
Increase the speed by removing for loop O(n) -> O(1)
Any other comments?