8000 CLN Update var name in `TargetEncoder` to make consistent by lucyleeow · Pull Request #27033 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

CLN Update var name in TargetEncoder to make consistent #27033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2023
Merged

CLN Update var name in TargetEncoder to make consistent #27033

merged 1 commit into from
Aug 8, 2023

Conversation

lucyleeow
Copy link
Member

Reference Issues/PRs

Make var name for X mask consistent in this file.
Related: #26674 (comment)

What does this implement/fix? Explain your changes.

Any other comments?

cc @thomasjpfan

@lucyleeow lucyleeow changed the title TST Update var name to make consistent Update var name in TargetEncoder to make consistent Aug 8, 2023
@lucyleeow lucyleeow mentioned this pull request Aug 8, 2023
Merged
4 tasks
@github-actions
Copy link
github-actions bot commented Aug 8, 2023

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 4bd770d. Link to the linter CI: here

@thomasjpfan thomasjpfan changed the title Update var name in TargetEncoder to make consistent MNT Update var name in TargetEncoder to make consistent Aug 8, 2023
@thomasjpfan thomasjpfan changed the title MNT Update var name in TargetEncoder to make consistent CLN Update var name in TargetEncoder to make consistent Aug 8, 2023
thomasjpfan
thomasjpfan approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan merged commit 5ecfa8d into scikit-learn:main Aug 8, 2023
@lucyleeow lucyleeow deleted the te branch August 8, 2023 23:11
TamaraAtanasoska pushed a commit to TamaraAtanasoska/scikit-learn that referenced this pull request Aug 21, 2023
@lucyleeow @TamaraAtanasoska
CLN Update var name in TargetEncoder to make consistent (scikit-lea…
fd4ed2b 
…rn#27033)
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Sep 18, 2023
@lucyleeow @glemaitre
CLN Update var name in TargetEncoder to make consistent (scikit-lea…
b1e98b2 
…rn#27033)
jeremiedbb pushed a commit that referenced this pull request Sep 20, 2023
@lucyleeow @jeremiedbb
CLN Update var name in TargetEncoder to make consistent (#27033)
4182eaa
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@lucyleeow @REDVM
CLN Update var name in TargetEncoder to make consistent (scikit-lea…
73f52db 
…rn#27033)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
module:preprocessing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucyleeow @thomasjpfan
0