8000 MNT Use assert_no_warnings from numpy.testing by thomasjpfan · Pull Request #27031 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

MNT Use assert_no_warnings from numpy.testing #27031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 9, 2023
Merged

MNT Use assert_no_warnings from numpy.testing #27031

merged 2 commits into from
Aug 9, 2023

Conversation

thomasjpfan
Copy link
Member

Reference Issues/PRs

Saw this reviewing #27013

What does this implement/fix? Explain your changes.

As noted by the comment, we can use assert_no_warnings directly from NumPy given our minimum support version is 1.17.3.

Any other comments?

We can rewrite the tests, turning warnings into errors, but I think a PR removing code is already a benefit.

@thomasjpfan thomasjpfan added module:test-suite everything related to our tests Quick Review For PRs that are quick to review labels Aug 7, 2023
@github-actions
Copy link
github-actions bot commented Aug 7, 2023 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 1193948. Link to the linter CI: here

OmarManzoor
OmarManzoor approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor
@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @thomasjpfan

@thomasjpfan thomasjpfan enabled auto-merge (squash) August 9, 2023 16:05
@thomasjpfan thomasjpfan merged commit fcaf0ff into scikit-learn:main Aug 9, 2023
TamaraAtanasoska pushed a commit to TamaraAtanasoska/scikit-learn that referenced this pull request Aug 21, 2023
@thomasjpfan @TamaraAtanasoska
MNT Use assert_no_warnings from numpy.testing (scikit-learn#27031)
4e082d6
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Sep 18, 2023
@thomasjpfan @glemaitre
MNT Use assert_no_warnings from numpy.testing (scikit-learn#27031)
78b0569
jeremiedbb pushed a commit that referenced this pull request Sep 20, 2023
@thomasjpfan @jeremiedbb
MNT Use assert_no_warnings from numpy.testing (#27031)
5b1eb92
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@thomasjpfan @REDVM
MNT Use assert_no_warnings from numpy.testing (scikit-learn#27031)
098a635
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betatim betatim betatim approved these changes

@OmarManzoor OmarManzoor OmarManzoor approved these changes

Assignees
No one assigned
Labels
module:test-suite everything related to our tests module:utils Quick Review For PRs that are quick to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasjpfan @betatim @OmarManzoor
0