10000 FIX missing_indices were calculated twice in OrdinalEncoder by xuefeng-xu · Pull Request #27017 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content
8000

FIX missing_indices were calculated twice in OrdinalEncoder #27017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 8, 2023
Merged

FIX missing_indices were calculated twice in OrdinalEncoder #27017

merged 4 commits into from
Aug 8, 2023

Conversation

xuefeng-xu
Copy link
Contributor

Reference Issues/PRs

Fixes #27011

@github-actions
Copy link
github-actions bot commented Aug 5, 2023 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 2063fa5. Link to the linter CI: here

@thomasjpfan thomasjpfan changed the title [MRG] FIX missing_indices were calculated twice in OrdinalEncoder FIX missing_indices were calculated twice in OrdinalEncoder Aug 7, 2023
thomasjpfan
thomasjpfan reviewed Aug 7, 2023
View reviewed changes
Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an entry to the change log at doc/whats_new/v1.4.rst with tag |Efficiency|. Like the other entries there, please reference this pull request with :pr: and credit yourself (and other contributors if applicable) with :user:.

Note that the changelog entry is public facing, so it is best to describe how this PR will impact a user.

thomasjpfan
thomasjpfan approved these changes Aug 7, 2023
View reviewed changes
@thomasjpfan thomasjpfan added the Waiting for Second Reviewer First reviewer is done, need a second one! label Aug 7, 2023
xuefeng-xu and others added 2 commits August 7, 2023 22:30
OmarManzoor
OmarManzoor approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor
@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks @xuefeng-xu

@OmarManzoor OmarManzoor removed the Waiting for Second Reviewer First reviewer is done, need a second one! label Aug 8, 2023
@OmarManzoor OmarManzoor merged commit 34c4741 into scikit-learn:main Aug 8, 2023
@xuefeng-xu xuefeng-xu mentioned this pull request Aug 8, 2023
Merged
@xuefeng-xu
Copy link
Contributor Author

Sorry, I forgot to add the :user: before my name in the change log. I have opened a PR to fix this, see #27036

@xuefeng-xu xuefeng-xu deleted the missing_indices branch August 8, 2023 12:41
TamaraAtanasoska pushed a commit to TamaraAtanasoska/scikit-learn that referenced this pull request Aug 21, 2023
@xuefeng-xu @thomasjpfan @TamaraAtanasoska
FIX missing_indices were calculated twice in OrdinalEncoder (scikit-l…
6ef7523 
…earn#27017)

Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@xuefeng-xu @thomasjpfan @REDVM
FIX missing_indices were calculated twice in OrdinalEncoder (scikit-l…
7e370e5 
…earn#27017)

Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

@OmarManzoor OmarManzoor OmarManzoor approved these changes

Assignees
No one assigned
Labels
module:preprocessing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xuefeng-xu @thomasjpfan @OmarManzoor
0