CI Only run arm tests nightly #26996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Micky774
reviewed
Aug 2, 2023
jjerphan
reviewed
Aug 7, 2023
There was a problem hiding this comment.
Thank you, @thomasjpfan.
I have a question and a suggestion.
.cirrus.star
Outdated
| if "[cd build]" in commit_msg or "[cd build cirrus]" in commit_msg: | ||
| return fs.read(arm_wheel_yaml) + fs.read(arm_tests_yaml) | ||
| return fs.read(arm_wheel_yaml) |
There was a problem hiding this comment.
Before running tests and building wheels was done together.
Are tests run when the wheels are built? If not, could we change the logic so that we can trigger both when several tags are present?
There was a problem hiding this comment.
I updated the PR to run the required jobs based on the tags. This means that if both [cd build] and [cirrus arm] is present, then both jobs run.
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
jjerphan
approved these changes
Aug 8, 2023
TamaraAtanasoska
pushed a commit
to TamaraAtanasoska/scikit-learn
that referenced
this pull request
Aug 21, 2023
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Sep 18, 2023
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
jeremiedbb
pushed a commit
that referenced
this pull request
Sep 20, 2023
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Closes #26879
What does this implement/fix? Explain your changes.
This PR makes the ARM test run nightly. This PR also adds a
[cirrus arm]commit tag to run the arm tests on CI if they are needed.