DOC improve the KNN classifier example #26993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinjalali
approved these changes
Aug 2, 2023
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
ArturoAmorQ
reviewed
Aug 3, 2023
There was a problem hiding this comment.
Just a couple of small comments, otherwise LGTM. Thanks @glemaitre :)
| # Conclusion | ||
| # ---------- | ||
| # | ||
| # We observe that the parameter `weights` has an impact on the decision boundary. When |
There was a problem hiding this comment.
It seems to be a very slight impact. I don't know if we can do something about it, though.
There was a problem hiding this comment.
Nop. I would expect to have a greater impact when you have neighbours that are actually far away but I don't think this is useful to build a toy example for that.
There was a problem hiding this comment.
It might be useful in higher-dimension. Not sure.
ArturoAmorQ
approved these changes
Aug 3, 2023
Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
TamaraAtanasoska
pushed a commit
to TamaraAtanasoska/scikit-learn
that referenced
this pull request
Aug 21, 2023
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com> Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Sep 18, 2023
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com> Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
jeremiedbb
pushed a commit
that referenced
this pull request
Sep 20, 2023
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com> Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com> Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving slightly the KNN classifier example.