8000 DOC adds dropdown for 10.3 Controlling Randomness by lazarust · Pull Request #26946 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

DOC adds dropdown for 10.3 Controlling Randomness #26946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 24, 2024
Merged

DOC adds dropdown for 10.3 Controlling Randomness #26946

merged 6 commits into from
Jan 24, 2024

Conversation

lazarust
Copy link
Contributor
@lazarust lazarust commented Jul 31, 2023 •
edited by ArturoAmorQ
Loading

Reference Issues/PRs

Addresses #26617

What does this implement/fix? Explain your changes.

Adds dropdown to https://scikit-learn.org/stable/common_pitfalls.html#controlling-randomness

Any other comments?

@github-actions
Copy link
github-actions bot commented Jul 31, 2023 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: d631d59. Link to the linter CI: here

@lazarust lazarust marked this pull request as ready for review July 31, 2023 01:07
@lazarust lazarust force-pushed the controlling-randomness-doc-dropdowns branch from d5d6218 to 5aa4f2f Compare August 1, 2023 01:40
@ArturoAmorQ ArturoAmorQ mentioned this pull request Aug 1, 2023
Closed
54 tasks
ArturoAmorQ
ArturoAmorQ reviewed Jan 17, 2024
View reviewed changes
@ArturoAmorQ
Copy link
Member
ArturoAmorQ commented Jan 18, 2024 •
edited
Loading

Thanks for the PR @lazarust and sorry for taking so long to answer. Now that you are working on this section, could you also please move the subsection 10.2.2. How to avoid data leakage right after the 3rd paragraph in 10.2. Data leakage i.e. right after:

Although both train and test data subsets should receive the same preprocessing [...]

and right before

An example of data leakage during preprocessing is detailed below.

Maybe we can also hide all the examples.

@lazarust lazarust force-pushed the controlling-randomness-doc-dropdowns branch from 97b5655 to d631d59 Compare January 24, 2024 01:01
@lazarust lazarust requested a review from ArturoAmorQ January 24, 2024 01:01
@lazarust
Copy link
Contributor Author

@ArturoAmorQ This is ready for you to look at again!

ArturoAmorQ
ArturoAmorQ approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member
@ArturoAmorQ ArturoAmorQ left a comment
8000

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lazarust this is already an improvement. LGTM, merging!

@ArturoAmorQ ArturoAmorQ merged commit 2eb5722 into scikit-learn:main Jan 24, 2024
@lazarust lazarust deleted the controlling-randomness-doc-dropdowns branch January 24, 2024 14:21
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Feb 10, 2024
@lazarust @glemaitre
DOC adds dropdown for 10.3 Controlling Randomness (scikit-learn#26946)
531d3d9
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Feb 13, 2024
@lazarust @glemaitre
DOC adds dropdown for 10.3 Controlling Randomness (scikit-learn#26946)
62be10a
glemaitre pushed a commit that referenced this pull request Feb 13, 2024
@lazarust @glemaitre
DOC adds dropdown for 10.3 Controlling Randomness (#26946)
312c08e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArturoAmorQ ArturoAmorQ ArturoAmorQ approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lazarust @ArturoAmorQ
0