8000 ENH Improve warnings if func returns a dataframe in FunctionTransformer by thomasjpfan · Pull Request #26944 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

ENH Improve warnings if func returns a dataframe in FunctionTransformer #26944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 19, 2023
Merged

ENH Improve warnings if func returns a dataframe in FunctionTransformer #26944

merged 5 commits into from
Sep 19, 2023

Conversation

thomasjpfan
Copy link
Member

Reference Issues/PRs

Closes #26552

What does this implement/fix? Explain your changes.

This PR implements the suggestion in #26552 (comment). The warning is now delayed to transform and not in set_output.

@github-actions
Copy link
github-actions bot commented Jul 30, 2023 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 15b9b14. Link to the linter CI: here

@thomasjpfan thomasjpfan mentioned this pull request Jul 30, 2023
Closed
@glemaitre glemaitre self-requested a review August 12, 2023 10:54
glemaitre
glemaitre approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member
@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on my side. Thanks @thomasjpfan

ogrisel
ogrisel approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member
@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find the use of the present tense in the warning message a bit confusing (see below) but other than that LGTM. Thanks for the UX fix!

thomasjpfan and others added 2 commits August 30, 2023 15:00
@glemaitre glemaitre merged commit 89ea028 into scikit-learn:main Sep 19, 2023
@glemaitre
Copy link
Member

Thanks @thomasjpfan

lesteve pushed a commit to lesteve/scikit-learn that referenced this pull request Sep 28, 2023
@thomasjpfan @ogrisel @lesteve
ENH Improve warnings if func returns a dataframe in FunctionTransform…
51ed83a 
…er (scikit-learn#26944)

Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@thomasjpfan @ogrisel @REDVM
ENH Improve warnings if func returns a dataframe in FunctionTransform…
0497c77 
…er (scikit-learn#26944)

Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@glemaitre glemaitre glemaitre approved these changes

Assignees
No one assigned
Labels
module:preprocessing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False positive warning in FunctionTransformer
3 participants
@thomasjpfan @glemaitre @ogrisel
0